-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Internship, Application and Item classes #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks great, thanks for the great effort and for doing this up so swiftly! I've added some questions/suggestions, and apologies if I misunderstood anything. They mostly stem from some concerns / perhaps not fully understanding your implementation. As there may be quite a bit to discuss, perhaps we can go over them during a meeting!
src/main/java/seedu/address/model/internship/InternshipItem.java
Outdated
Show resolved
Hide resolved
I noticed that many of the javadocs used "person" and "address book", should we change it now? or leave it for later? |
Hmm. The dilemma now is that this is just a proof of concept and we may be abstracting common logic down the line and scrapping all these, so overwriting Javadocs now may redundant. The danger is that if the code is kept and the comments are missed in the future. What is the team's opinion on this? @ZoroarkDarkrai @keanecjy @seanjyjy @shawn-nyk |
If we are planning to create other classes in replacement of person and address book, I don't think we need to change the Javadoc yet? |
Yup I think that there isn't a need to concern about javadocs / comments as of now as they can be easily fixed at any point in time. @orzymandias I stopped editing the List portions as I noticed that there were too much code duplication with your pr. Do we plan to either extend an |
I agree. I think there is unnecessary duplication for collections, generics is a good idea for collections but one issue is with throwing custom exceptions for different types of items within the generic list. Should we just have DuplicateItemException then something like |
I don't think this works because we are not able to access methods in java generics. I figured since we all are classifying our classes as |
Sounds good. |
I agree that overwriting Javadocs now may be redundant, especially because our code can change over time up until the final version. At the same time, I also agree that we may miss them in the future, and doing a one-time run-through of all our code at the end may be very tedious and error-prone. As such, how about we do something like: every time we create new bits of code that require Javadocs, or we modify code that already has Javadocs attached to them, we place a standardized comment, such as |
I think this is a great idea what do the rest think? |
Sure, I think this is a solid idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great! Perhaps just a few minor edits and I think we're good to merge!
src/main/java/seedu/address/model/internship/InternshipItem.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Include for data fields and Item list