Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sg ppp #172

Merged
merged 3 commits into from
Nov 4, 2020
Merged

Update sg ppp #172

merged 3 commits into from
Nov 4, 2020

Conversation

sgn00
Copy link

@sgn00 sgn00 commented Nov 4, 2020

No description provided.

@sgn00 sgn00 added this to the v1.4 milestone Nov 4, 2020
@sgn00 sgn00 self-assigned this Nov 4, 2020
@sgn00 sgn00 requested a review from moyj01 November 4, 2020 07:30
@codecov-io
Copy link

codecov-io commented Nov 4, 2020

Codecov Report

Merging #172 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #172      +/-   ##
============================================
- Coverage     64.68%   64.59%   -0.10%     
  Complexity      588      588              
============================================
  Files           108      108              
  Lines          2005     2008       +3     
  Branches        223      223              
============================================
  Hits           1297     1297              
- Misses          627      630       +3     
  Partials         81       81              
Impacted Files Coverage Δ Complexity Δ
...java/seedu/flashcard/model/flashcard/Category.java 90.00% <0.00%> (ø) 9.00% <0.00%> (ø%)
...java/seedu/flashcard/ui/FlashcardQuestionCard.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...va/seedu/flashcard/logic/commands/SortCommand.java 100.00% <0.00%> (ø) 7.00% <0.00%> (ø%)
...va/seedu/flashcard/logic/commands/ViewCommand.java 100.00% <0.00%> (ø) 9.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 059cc56...a323af3. Read the comment docs.

Copy link

@moyj01 moyj01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, please take a look at my comments

* **New Feature**: Added the ability to review flashcards.
* What it does: allows the user to enter an interactive review mode where the user can use arrow keys
to show a flashcard's answer, move to the next flashcard or move to previous flashcard.
* Justification: This features allows users to review their flashcards in a sandbox mode, allowing them to study the flashcards
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these features or this feature

* **Project management**:
* **New Feature**: Added the ability to view flashcards.
* What it does: allows user to view a flashcard in the view pane with or without the answer shown.
* Justification: This features allows users to see the flashcards in detail with the full question, answer, diagrams and notes.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

* **New Feature**: Added rating to flashcards.
* What it does: allows user to specify a star rating attribute to the flashcard.
* Justification: The star rating is intended to mirror the CS2103 website which provides star rating for different objectives.
This allows user to map their learning from CS2103 website over to our flashcards better.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows the user.

@sgn00 sgn00 merged commit 45d6fd4 into AY2021S1-CS2103T-T17-2:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants