Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input table to ug #189

Merged
merged 8 commits into from
Nov 6, 2020
Merged

Conversation

sgn00
Copy link

@sgn00 sgn00 commented Nov 5, 2020

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 5, 2020

Codecov Report

Merging #189 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #189   +/-   ##
=========================================
  Coverage     64.59%   64.59%           
  Complexity      588      588           
=========================================
  Files           108      108           
  Lines          2008     2008           
  Branches        223      223           
=========================================
  Hits           1297     1297           
  Misses          630      630           
  Partials         81       81           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2f17d0...883445a. Read the comment docs.

@sgn00 sgn00 requested a review from moyj01 November 5, 2020 11:05
Copy link

@moyj01 moyj01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some inputs

<div markdown="block" class="alert alert-info">

**:information_source: Notes about the command format:**<br>

* Words in UPPER_CASE are the parameters to be supplied by the user.<br>
e.g. in add `q/QUESTION`, `QUESTION` is a parameter which can be used as `add q/`What is my name?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first add needs to be placed in

Comment on lines 198 to 199
* Specifying empty values to NOTE, RATING, TAG or DIAGRAM eg. `r/` will remove the corresponding field in the flashcard.
* Although QUESTION, ANSWER and CATEGORY are optional values, you are not allowed to specify an empty value to those attributes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if NOTE, RATING ,TAG etc needs to be in

@sgn00 sgn00 linked an issue Nov 5, 2020 that may be closed by this pull request
@sgn00 sgn00 linked an issue Nov 5, 2020 that may be closed by this pull request
@sgn00 sgn00 self-assigned this Nov 6, 2020
Copy link

@moyj01 moyj01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgn00 sgn00 merged commit e6dd8fe into AY2021S1-CS2103T-T17-2:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add behaviour about sort and filter in UG Update input format in UG
3 participants