Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update review dg #190

Merged
merged 5 commits into from
Nov 6, 2020
Merged

Conversation

sgn00
Copy link

@sgn00 sgn00 commented Nov 5, 2020

No description provided.

@sgn00 sgn00 requested a review from moyj01 November 5, 2020 17:52
@codecov-io
Copy link

Codecov Report

Merging #190 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #190   +/-   ##
=========================================
  Coverage     64.59%   64.59%           
  Complexity      588      588           
=========================================
  Files           108      108           
  Lines          2008     2008           
  Branches        223      223           
=========================================
  Hits           1297     1297           
  Misses          630      630           
  Partials         81       81           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fb7e0b...ce08e38. Read the comment docs.

@sgn00 sgn00 requested a review from minzzelo November 5, 2020 18:44
Copy link

@minzzelo minzzelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sgn00 sgn00 merged commit 77f63cf into AY2021S1-CS2103T-T17-2:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants