Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filter implementation in DG #210

Merged

Conversation

tan-zhuoyao
Copy link

No description provided.

@tan-zhuoyao tan-zhuoyao added this to the v1.4 milestone Nov 6, 2020
@tan-zhuoyao tan-zhuoyao self-assigned this Nov 6, 2020
@tan-zhuoyao tan-zhuoyao linked an issue Nov 6, 2020 that may be closed by this pull request
Copy link

@sgn00 sgn00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…into update-dg-filter

* 'master' of https://github.com/AY2021S1-CS2103T-T17-2/tp:
  Add caveat on input prefixes
  update diagram
  Update review class diagram
  Edit ratings of pre loaded question and edit index.md image
  Update review class diagram
  Fix UI Class Diagram
  Edit grammar of sample data
  Edit grammar in sample data
  Remove FAQ section in ug
  Edit spacing in sample data
  Edit annotated diagram
  Minor fix to dg
  Add annotated diagram and populate sample data into application
@codecov-io
Copy link

Codecov Report

Merging #210 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #210   +/-   ##
=========================================
  Coverage     64.33%   64.33%           
  Complexity      588      588           
=========================================
  Files           108      108           
  Lines          2016     2016           
  Branches        223      223           
=========================================
  Hits           1297     1297           
  Misses          638      638           
  Partials         81       81           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fd7567...7578a29. Read the comment docs.

@tan-zhuoyao tan-zhuoyao merged commit 4f26074 into AY2021S1-CS2103T-T17-2:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update filter feature in DG
3 participants