Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UC inclusion, fix quiz and review key syntax #219

Merged

Conversation

minzzelo
Copy link

@minzzelo minzzelo commented Nov 7, 2020

No description provided.

@minzzelo minzzelo self-assigned this Nov 7, 2020
Copy link

@kimberlyohq kimberlyohq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than some minor changes

docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
@minzzelo minzzelo merged commit 3c41f58 into AY2021S1-CS2103T-T17-2:master Nov 7, 2020
@@ -712,18 +681,32 @@ Priorities: High (must have) - `* * *`, Medium (nice to have) - `* *`, Low (unli

Use case ends.

* 3a. User requests to hide the answer.

Use case ends.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the use case should resumes from 2/4?


* 3b. User requests to show the previous flashcard (if there is a previous flashcard).

Use case ends.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the use case should resume from step 2?


Use case ends.

* a. At any time, User requests to quit review mode.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think u forgot to add *a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants