-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor diagram to only support certain file types. #249
Refactor diagram to only support certain file types. #249
Conversation
moyj01
commented
Nov 8, 2020
- Refactor diagram
- Change error message
- Added a String Array of supported file type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refer comment
if (isAcceptedImageFileType(file)) { | ||
if (ImageIO.read(file) != null) { | ||
return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe can put in same line with && for better code quality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…into branch-update-diagram-limit-file-types