Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor diagram to only support certain file types. #249

Conversation

moyj01
Copy link

@moyj01 moyj01 commented Nov 8, 2020

  1. Refactor diagram
  2. Change error message
  3. Added a String Array of supported file type

@moyj01 moyj01 added this to the v1.4 milestone Nov 8, 2020
@moyj01 moyj01 requested a review from sgn00 November 8, 2020 03:35
Copy link

@sgn00 sgn00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer comment

Comment on lines 42 to 44
if (isAcceptedImageFileType(file)) {
if (ImageIO.read(file) != null) {
return true;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe can put in same line with && for better code quality?

Copy link

@sgn00 sgn00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moyj01 moyj01 merged commit d6bd901 into AY2021S1-CS2103T-T17-2:master Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants