Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor UniquePersonList to UniqueFlashcardList #26

Merged
merged 8 commits into from
Sep 22, 2020
Merged

Refactor UniquePersonList to UniqueFlashcardList #26

merged 8 commits into from
Sep 22, 2020

Conversation

kimberlyohq
Copy link

This PR:

  • Refactor UniquePersonList to UniqueFlashcardList

  • Add tests for UniqueFlashcardList

  • Rename all person occurrences to flashcard

  • Rename person package to flashcard

@kimberlyohq kimberlyohq self-assigned this Sep 22, 2020
@kimberlyohq kimberlyohq added this to the v1.1 milestone Sep 22, 2020
@kimberlyohq kimberlyohq linked an issue Sep 22, 2020 that may be closed by this pull request
Refactor UniquePersonList to UniqueFlashcardList #15
Closed
@kimberlyohq kimberlyohq removed this from the v1.1 milestone Sep 22, 2020
minzzelo
minzzelo approved these changes Sep 22, 2020
View reviewed changes
Copy link

@minzzelo minzzelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@kimberlyohq kimberlyohq merged commit daa8b0f into AY2021S1-CS2103T-T17-2:master Sep 22, 2020
@kimberlyohq kimberlyohq added this to the v1.1 milestone Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minzzelo minzzelo minzzelo approved these changes

Assignees

@kimberlyohq kimberlyohq

Labels
None yet
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

Refactor UniquePersonList to UniqueFlashcardList
2 participants
@kimberlyohq @minzzelo