Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor findcommandtest and findcommandparsertest #57

Merged
merged 4 commits into from
Oct 14, 2020
Merged

Refactor findcommandtest and findcommandparsertest #57

merged 4 commits into from
Oct 14, 2020

Conversation

tan-zhuoyao
Copy link

No description provided.

…into add-filtercommandtest

* 'master' of https://github.com/AY2021S1-CS2103T-T17-2/tp:
  Refactor filter command
  Checkstyle fix
  Refactor ClearCommand and tests
  Refactor QuestionContainsKeywordsPredicate
  Refactor EditCommand and EditCommandParser
  Refactor FindCommand
* add-filtercommandtest:
  Refactor filter command
  Checkstyle fix
  Refactor ClearCommand and tests
  Refactor QuestionContainsKeywordsPredicate
  Refactor EditCommand and EditCommandParser
  Refactor FindCommand
  Rename tests
  Add tests for multiple filters in FilterCommandTest
@tan-zhuoyao tan-zhuoyao added this to the v1.2 milestone Oct 13, 2020
@tan-zhuoyao tan-zhuoyao self-assigned this Oct 13, 2020
@tan-zhuoyao tan-zhuoyao linked an issue Oct 13, 2020 that may be closed by this pull request
@codecov-io
Copy link

Codecov Report

Merging #57 into master will increase coverage by 0.45%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #57      +/-   ##
============================================
+ Coverage     60.65%   61.11%   +0.45%     
- Complexity      365      369       +4     
============================================
  Files            80       80              
  Lines          1314     1314              
  Branches        123      123              
============================================
+ Hits            797      803       +6     
+ Misses          473      469       -4     
+ Partials         44       42       -2     
Impacted Files Coverage Δ Complexity Δ
...java/seedu/address/logic/commands/FindCommand.java 100.00% <0.00%> (+66.66%) 6.00% <0.00%> (+4.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7785063...ca50e83. Read the comment docs.

Copy link

@kimberlyohq kimberlyohq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tan-zhuoyao tan-zhuoyao merged commit 821a1c1 into AY2021S1-CS2103T-T17-2:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor FindCommandTest and FindCommandParserTest
3 participants