Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor review #94

Merged
merged 7 commits into from
Oct 23, 2020
Merged

Refactor review #94

merged 7 commits into from
Oct 23, 2020

Conversation

sgn00
Copy link

@sgn00 sgn00 commented Oct 23, 2020

  1. Move review code in MainWindow to ReviewPanel
  2. ReviewPanel inherits from StudyPanel, to allow extension of quiz feature later

@sgn00 sgn00 added this to the v1.3 milestone Oct 23, 2020
@sgn00 sgn00 requested a review from moyj01 October 23, 2020 10:45
@sgn00 sgn00 self-assigned this Oct 23, 2020
moyj01
moyj01 approved these changes Oct 23, 2020
View reviewed changes
Copy link

@moyj01 moyj01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great use of OOP . LGTM

@moyj01 moyj01 merged commit 6ddb823 into AY2021S1-CS2103T-T17-2:master Oct 23, 2020
@sgn00 sgn00 linked an issue Oct 24, 2020 that may be closed by this pull request
Implement quiz feature #90
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moyj01 moyj01 moyj01 approved these changes

Assignees

@sgn00 sgn00

Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Implement quiz feature
2 participants
@sgn00 @moyj01