Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Sort for flashcards #95

Merged
merged 4 commits into from
Oct 24, 2020

Conversation

minzzelo
Copy link

Resolves #71

@minzzelo minzzelo added this to the v1.3 milestone Oct 23, 2020
@minzzelo minzzelo self-assigned this Oct 23, 2020
@codecov-io
Copy link

codecov-io commented Oct 23, 2020

Codecov Report

Merging #95 into master will increase coverage by 0.96%.
The diff coverage is 94.73%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #95      +/-   ##
============================================
+ Coverage     63.94%   64.90%   +0.96%     
- Complexity      491      511      +20     
============================================
  Files            94       97       +3     
  Lines          1725     1781      +56     
  Branches        190      197       +7     
============================================
+ Hits           1103     1156      +53     
- Misses          550      551       +1     
- Partials         72       74       +2     
Impacted Files Coverage Δ Complexity Δ
...du/flashcard/logic/parser/FlashcardDeckParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/flashcard/model/Model.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...eedu/flashcard/logic/parser/SortCommandParser.java 85.71% <85.71%> (ø) 5.00 <5.00> (?)
...va/seedu/flashcard/logic/commands/SortCommand.java 100.00% <100.00%> (ø) 7.00 <7.00> (?)
...n/java/seedu/flashcard/logic/parser/CliSyntax.java 88.88% <100.00%> (+1.38%) 1.00 <0.00> (ø)
.../java/seedu/flashcard/logic/parser/ParserUtil.java 95.23% <100.00%> (+0.59%) 22.00 <2.00> (+2.00)
.../main/java/seedu/flashcard/model/ModelManager.java 67.30% <100.00%> (+3.47%) 14.00 <1.00> (+1.00)
.../seedu/flashcard/model/flashcard/SortCriteria.java 100.00% <100.00%> (ø) 5.00 <5.00> (?)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ddb823...453a69c. Read the comment docs.

@minzzelo minzzelo requested a review from sgn00 October 24, 2020 02:45
Copy link

@sgn00 sgn00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@minzzelo minzzelo merged commit 5625ed3 into AY2021S1-CS2103T-T17-2:master Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Sort Feature to sort flashcards by least/most reviewed, most wrong, rating
3 participants