Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement quiz feature #96

Merged
merged 5 commits into from
Oct 24, 2020

Conversation

moyj01
Copy link

@moyj01 moyj01 commented Oct 23, 2020

No description provided.

@moyj01 moyj01 added this to the v1.3 milestone Oct 23, 2020
@moyj01 moyj01 requested a review from sgn00 October 23, 2020 18:02
@moyj01 moyj01 self-assigned this Oct 23, 2020
@sgn00 sgn00 self-assigned this Oct 24, 2020
@codecov-io
Copy link

codecov-io commented Oct 24, 2020

Codecov Report

Merging #96 into master will decrease coverage by 2.14%.
The diff coverage is 20.32%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #96      +/-   ##
============================================
- Coverage     63.58%   61.44%   -2.15%     
- Complexity      525      536      +11     
============================================
  Files           101      104       +3     
  Lines          1862     1953      +91     
  Branches        219      224       +5     
============================================
+ Hits           1184     1200      +16     
- Misses          593      668      +75     
  Partials         85       85              
Impacted Files Coverage Δ Complexity Δ
.../main/java/seedu/flashcard/logic/LogicManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...lashcard/logic/commands/IncrementStatsCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...va/seedu/flashcard/logic/commands/QuizCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...du/flashcard/logic/parser/FlashcardDeckParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/flashcard/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/flashcard/ui/QuizPanel.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
src/main/java/seedu/flashcard/ui/ReviewPanel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/flashcard/ui/StudyPanel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../seedu/flashcard/logic/commands/CommandResult.java 55.88% <60.00%> (-2.19%) 12.00 <2.00> (+1.00) ⬇️
.../main/java/seedu/flashcard/logic/StudyManager.java 67.85% <67.85%> (ø) 10.00 <10.00> (?)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e384b6...c360b50. Read the comment docs.

Copy link

@sgn00 sgn00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgn00 sgn00 merged commit bfc3512 into AY2021S1-CS2103T-T17-2:master Oct 24, 2020
@sgn00 sgn00 linked an issue Oct 24, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement quiz feature
3 participants