Skip to content
This repository has been archived by the owner on Jan 11, 2021. It is now read-only.

Update Class Diagram for UI component in DG #127

Conversation

vanGoghhh
Copy link
Collaborator

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #127 into master will increase coverage by 1.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #127      +/-   ##
============================================
+ Coverage     75.83%   77.04%   +1.21%     
- Complexity      626      724      +98     
============================================
  Files            94      106      +12     
  Lines          1924     2130     +206     
  Branches        235      269      +34     
============================================
+ Hits           1459     1641     +182     
- Misses          407      417      +10     
- Partials         58       72      +14     
Impacted Files Coverage Δ Complexity Δ
...in/java/seedu/address/commons/util/StringUtil.java 88.88% <0.00%> (-5.85%) 8.00% <0.00%> (+1.00%) ⬇️
.../java/seedu/address/storage/JsonAdaptedPerson.java 97.50% <0.00%> (-2.50%) 23.00% <0.00%> (+3.00%) ⬇️
...n/java/seedu/address/model/information/Person.java 90.76% <0.00%> (-2.09%) 29.00% <0.00%> (+2.00%) ⬇️
...main/java/seedu/address/model/information/Job.java 92.85% <0.00%> (-1.27%) 23.00% <0.00%> (+1.00%) ⬇️
src/main/java/seedu/address/ui/JobCard.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
src/main/java/seedu/address/ui/PersonCard.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...ain/java/seedu/address/storage/JsonAdaptedJob.java 100.00% <0.00%> (ø) 17.00% <0.00%> (+2.00%)
.../java/seedu/address/model/util/SampleDataUtil.java 8.10% <0.00%> (ø) 1.00% <0.00%> (ø%)
...va/seedu/address/logic/commands/AddJobCommand.java 100.00% <0.00%> (ø) 8.00% <0.00%> (ø%)
...seedu/address/logic/commands/AddPersonCommand.java 100.00% <0.00%> (ø) 8.00% <0.00%> (ø%)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fb312d...e9b7040. Read the comment docs.

Copy link
Collaborator

@LeeJoonJie LeeJoonJie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeeJoonJie LeeJoonJie merged commit 4f2ad8d into AY2021S1-CS2103T-T17-3:master Oct 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants