Skip to content
This repository has been archived by the owner on Jan 11, 2021. It is now read-only.

update DG #138

Merged
merged 2 commits into from
Oct 23, 2020
Merged

Conversation

raythx98
Copy link

Update DG
Add some test cases

@codecov-io
Copy link

Codecov Report

Merging #138 into master will increase coverage by 3.03%.
The diff coverage is 8.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #138      +/-   ##
============================================
+ Coverage     73.09%   76.12%   +3.03%     
- Complexity      723      787      +64     
============================================
  Files           118      118              
  Lines          2241     2245       +4     
  Branches        283      285       +2     
============================================
+ Hits           1638     1709      +71     
+ Misses          531      460      -71     
- Partials         72       76       +4     
Impacted Files Coverage Δ Complexity Δ
...seedu/address/logic/commands/AddPersonCommand.java 100.00% <ø> (ø) 8.00 <0.00> (ø)
...eedu/address/logic/commands/SortPersonCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../address/logic/parser/EditPersonCommandParser.java 90.19% <ø> (ø) 22.00 <0.00> (ø)
...in/java/seedu/address/logic/parser/ParserUtil.java 92.40% <0.00%> (-6.25%) 30.00 <0.00> (ø)
.../address/logic/parser/SortPersonCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...java/seedu/address/model/information/Priority.java 66.66% <0.00%> (-13.34%) 10.00 <1.00> (+1.00) ⬇️
...cate/PersonBlacklistContainsKeywordsPredicate.java 100.00% <ø> (+100.00%) 7.00 <0.00> (+7.00)
.../predicate/PersonTagsContainKeywordsPredicate.java 100.00% <ø> (+100.00%) 8.00 <0.00> (+8.00)
...ain/java/seedu/address/logic/parser/CliSyntax.java 94.11% <100.00%> (+0.78%) 1.00 <0.00> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 763f97c...4ae9611. Read the comment docs.

Copy link
Collaborator

@LeeJoonJie LeeJoonJie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LeeJoonJie LeeJoonJie merged commit 824f995 into AY2021S1-CS2103T-T17-3:master Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants