Skip to content
This repository has been archived by the owner on Jan 11, 2021. It is now read-only.

Add tests for View Commands #290

Conversation

vanGoghhh
Copy link
Collaborator

@vanGoghhh vanGoghhh commented Nov 4, 2020

Closes #265

@codecov-io
Copy link

Codecov Report

Merging #290 into master will increase coverage by 2.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #290      +/-   ##
============================================
+ Coverage     75.36%   77.50%   +2.14%     
- Complexity      957      981      +24     
============================================
  Files           137      137              
  Lines          2703     2703              
  Branches        340      340              
============================================
+ Hits           2037     2095      +58     
+ Misses          572      522      -50     
+ Partials         94       86       -8     
Impacted Files Coverage Δ Complexity Δ
.../java/seedu/address/storage/JsonAdaptedPerson.java 100.00% <0.00%> (+2.50%) 23.00% <0.00%> (+1.00%)
.../address/logic/parser/FindPersonCommandParser.java 98.57% <0.00%> (+4.28%) 17.00% <0.00%> (+1.00%)
.../seedu/address/logic/parser/AddressBookParser.java 100.00% <0.00%> (+5.26%) 25.00% <0.00%> (+1.00%)
...rc/main/java/seedu/address/model/ModelManager.java 98.90% <0.00%> (+8.79%) 41.00% <0.00%> (+4.00%)
...edu/address/logic/parser/FindJobCommandParser.java 91.66% <0.00%> (+31.66%) 15.00% <0.00%> (+5.00%)
...edu/address/logic/parser/ViewJobCommandParser.java 100.00% <0.00%> (+50.00%) 2.00% <0.00%> (ø%)
.../address/logic/parser/ViewPersonCommandParser.java 100.00% <0.00%> (+50.00%) 2.00% <0.00%> (ø%)
...a/seedu/address/logic/commands/ViewJobCommand.java 100.00% <0.00%> (+75.00%) 7.00% <0.00%> (+6.00%)
...eedu/address/logic/commands/ViewPersonCommand.java 100.00% <0.00%> (+75.00%) 7.00% <0.00%> (+6.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f9930f...25fe0bf. Read the comment docs.

Copy link
Collaborator

@g-erm g-erm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@g-erm g-erm merged commit ff2f591 into AY2021S1-CS2103T-T17-3:master Nov 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement tests for view person/job command
3 participants