Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage handling for TagTask and MeetingLink #142

Merged
merged 7 commits into from
Oct 29, 2020

Conversation

yeo-kexin
Copy link

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #142 into master will decrease coverage by 1.25%.
The diff coverage is 22.03%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #142      +/-   ##
============================================
- Coverage     71.74%   70.49%   -1.26%     
+ Complexity      576      574       -2     
============================================
  Files            96       97       +1     
  Lines          1759     1803      +44     
  Branches        191      199       +8     
============================================
+ Hits           1262     1271       +9     
- Misses          452      481      +29     
- Partials         45       51       +6     
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/model/tag/Tag.java 77.77% <0.00%> (-15.56%) 13.00 <0.00> (ø)
.../java/seedu/address/model/util/SampleDataUtil.java 8.10% <0.00%> (ø) 1.00 <0.00> (ø)
...java/seedu/address/storage/JsonAdaptedTagTask.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...java/seedu/address/storage/JsonProjactStorage.java 85.71% <0.00%> (ø) 8.00 <0.00> (ø)
...seedu/address/storage/JsonSerializableProjact.java 91.66% <ø> (ø) 5.00 <0.00> (ø)
...ain/java/seedu/address/storage/JsonAdaptedTag.java 51.42% <46.42%> (-30.39%) 2.00 <2.00> (-2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87a8a47...5997e3a. Read the comment docs.

Copy link

@siqiang-ng siqiang-ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoeyToh JoeyToh added this to the v1.4 milestone Oct 29, 2020
Copy link

@JoeyToh JoeyToh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@siqiang-ng siqiang-ng merged commit 691f12c into AY2021S1-CS2103T-T17-4:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants