Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Email's regex to check for domain extension #218

Merged
merged 3 commits into from
Nov 6, 2020
Merged

Edit Email's regex to check for domain extension #218

merged 3 commits into from
Nov 6, 2020

Conversation

yeo-kexin
Copy link

Other changes:

  • Add more Email tests to reflect the change in regex

This was linked to issues Nov 5, 2020
[PE-D] Regex for email is inaccurate #181
Closed
[PE-D] Add command (email parameter) #163
Closed
@yeo-kexin yeo-kexin added this to the v1.4 milestone Nov 5, 2020
JoeyToh
JoeyToh approved these changes Nov 6, 2020
View reviewed changes
Copy link

@JoeyToh JoeyToh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@siqiang-ng siqiang-ng merged commit 524da21 into AY2021S1-CS2103T-T17-4:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siqiang-ng siqiang-ng siqiang-ng approved these changes

@JoeyToh JoeyToh JoeyToh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

[PE-D] Regex for email is inaccurate [PE-D] Add command (email parameter)
3 participants
@yeo-kexin @siqiang-ng @JoeyToh