Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TagFindCommand #65

Merged

Conversation

akgrenSoar
Copy link

@akgrenSoar akgrenSoar commented Oct 12, 2020

Closes #67

Add TagFindCommand changelog:

  • Add TagFindCommand
  • Update Userguide
  • Add relevant unit tests

Other Changes:

  • TagName now allow spaces
  • Commands in UserGuide are now in lowercase

@codecov-io
Copy link

codecov-io commented Oct 12, 2020

Codecov Report

Merging #65 into master will increase coverage by 0.61%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #65      +/-   ##
============================================
+ Coverage     69.30%   69.92%   +0.61%     
- Complexity      426      442      +16     
============================================
  Files            77       80       +3     
  Lines          1362     1390      +28     
  Branches        139      142       +3     
============================================
+ Hits            944      972      +28     
  Misses          387      387              
  Partials         31       31              
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...a/seedu/address/logic/commands/TagListCommand.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
src/main/java/seedu/address/model/tag/TagName.java 90.00% <ø> (ø) 7.00 <0.00> (ø)
...a/seedu/address/logic/commands/TagFindCommand.java 100.00% <100.00%> (ø) 5.00 <5.00> (?)
...java/seedu/address/logic/parser/ProjactParser.java 100.00% <100.00%> (ø) 14.00 <0.00> (+1.00)
...edu/address/logic/parser/TagFindCommandParser.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)
...ss/model/tag/TagNameContainsKeywordsPredicate.java 100.00% <100.00%> (ø) 7.00 <7.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 847f687...6295591. Read the comment docs.

docs/UserGuide.md Outdated Show resolved Hide resolved
Copy link

@siqiang-ng siqiang-ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the above comment to clarify

Copy link

@yeo-kexin yeo-kexin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve merge conflicts in TagBuilder.java

@akgrenSoar akgrenSoar added this to the v1.2 milestone Oct 13, 2020
Copy link

@yeo-kexin yeo-kexin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yeo-kexin yeo-kexin closed this Oct 14, 2020
@yeo-kexin yeo-kexin reopened this Oct 14, 2020
@yeo-kexin yeo-kexin merged commit d80be42 into AY2021S1-CS2103T-T17-4:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As an user, I can search for a tag
4 participants