Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SearchRecipeCommand and add RecommendCommand #109

Merged

Conversation

caitlinjee
Copy link
Collaborator

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 16, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@07fd783). Click here to learn what that means.
The diff coverage is 18.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #109   +/-   ##
=========================================
  Coverage          ?   62.40%           
  Complexity        ?      529           
=========================================
  Files             ?      102           
  Lines             ?     1915           
  Branches          ?      222           
=========================================
  Hits              ?     1195           
  Misses            ?      645           
  Partials          ?       75           
Impacted Files Coverage Δ Complexity Δ
...address/logic/commands/ListConsumptionCommand.java 100.00% <ø> (ø) 3.00 <0.00> (?)
...seedu/address/logic/commands/RecommendCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...u/address/logic/parser/WishfulShrinkingParser.java 84.00% <0.00%> (ø) 17.00 <0.00> (?)
...del/recipe/RecipeContainsIngredientsPredicate.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...seedu/address/model/recipe/RecommendPredicate.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ess/model/recipe/TagContainsKeywordsPredicate.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ddress/logic/parser/SearchRecipeCommandParser.java 41.93% <37.50%> (ø) 5.00 <1.00> (?)
.../model/recipe/RecipeContainsKeywordsPredicate.java 42.85% <42.85%> (ø) 1.00 <1.00> (?)
...du/address/logic/commands/SearchRecipeCommand.java 100.00% <100.00%> (ø) 6.00 <1.00> (?)
...ss/model/recipe/NameContainsKeywordsPredicate.java 100.00% <100.00%> (ø) 7.00 <1.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07fd783...4abc107. Read the comment docs.

Copy link
Collaborator

@oliviajohansen oliviajohansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok, are you planning to add tests?

Copy link
Collaborator

@oliviajohansen oliviajohansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@TianYong-Goh TianYong-Goh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@jiaqi20 jiaqi20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@caitlinjee caitlinjee merged commit 7e55059 into AY2021S1-CS2103T-W10-2:master Oct 16, 2020
@caitlinjee caitlinjee self-assigned this Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants