Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchRecipe and Recommend Command Test #116

Conversation

TianYong-Goh
Copy link
Collaborator

No description provided.

@TianYong-Goh TianYong-Goh added this to the v1.3 milestone Oct 18, 2020
@TianYong-Goh TianYong-Goh self-assigned this Oct 18, 2020
@TianYong-Goh TianYong-Goh linked an issue Oct 18, 2020 that may be closed by this pull request
@TianYong-Goh TianYong-Goh changed the title Search and Recommend Command Test SearchRecipe and Recommend Command Test Oct 18, 2020
@codecov-io
Copy link

codecov-io commented Oct 18, 2020

Codecov Report

Merging #116 into master will increase coverage by 2.56%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #116      +/-   ##
============================================
+ Coverage     65.56%   68.12%   +2.56%     
- Complexity      594      638      +44     
============================================
  Files           108      108              
  Lines          2117     2121       +4     
  Branches        255      257       +2     
============================================
+ Hits           1388     1445      +57     
+ Misses          647      597      -50     
+ Partials         82       79       -3     
Impacted Files Coverage Δ Complexity Δ
...del/recipe/RecipeContainsIngredientsPredicate.java 100.00% <100.00%> (+100.00%) 8.00 <0.00> (+8.00)
...seedu/address/model/recipe/RecommendPredicate.java 100.00% <100.00%> (+100.00%) 10.00 <0.00> (+10.00)
...u/address/logic/parser/WishfulShrinkingParser.java 76.66% <0.00%> (+3.33%) 19.00% <0.00%> (+1.00%)
...ddress/logic/parser/SearchRecipeCommandParser.java 77.41% <0.00%> (+35.48%) 14.00% <0.00%> (+9.00%)
.../model/recipe/RecipeContainsKeywordsPredicate.java 100.00% <0.00%> (+57.14%) 7.00% <0.00%> (+6.00%)
...seedu/address/logic/commands/RecommendCommand.java 75.00% <0.00%> (+75.00%) 3.00% <0.00%> (+3.00%)
...ess/model/recipe/TagContainsKeywordsPredicate.java 100.00% <0.00%> (+100.00%) 7.00% <0.00%> (+7.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8357d24...0c2ead1. Read the comment docs.

Copy link
Collaborator

@oliviajohansen oliviajohansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@caitlinjee caitlinjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@jiaqi20 jiaqi20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TianYong-Goh TianYong-Goh merged commit b74fc6b into AY2021S1-CS2103T-W10-2:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for SearchRecipeCommand and RecommendCommand
6 participants