Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DevGuide and UserGuide (UI Class diagram + Select + Close Command) #177

Merged

Conversation

daongochieu2810
Copy link
Collaborator

No description provided.

@@ -232,12 +232,27 @@ Format: `deleteC INDEX`
Examples:
* `calories` followed by `deleteC 2` deletes the 2nd recipe in Consumption List.

### Clearing all consumption : `clearC'
### Clearing all consumption : `clearC`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping me to change this.

Examples:
* `selectR 1` shows the 1st recipe in full view (left drawer).

### Close left drawer : `close`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can try to rephase it? cause I don't think the user know what is a drawer. Maybe "Close the recipe full view" ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another option is adding drawer to glossary

Copy link
Collaborator

@oliviajohansen oliviajohansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@caitlinjee caitlinjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, agree with the suggestion to add drawer to glossary

Copy link
Collaborator

@jiaqi20 jiaqi20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-io
Copy link

Codecov Report

Merging #177 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #177   +/-   ##
=========================================
  Coverage     64.56%   64.56%           
  Complexity      685      685           
=========================================
  Files           116      116           
  Lines          2382     2382           
  Branches        294      294           
=========================================
  Hits           1538     1538           
  Misses          732      732           
  Partials        112      112           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b20ad81...7f564e0. Read the comment docs.

@daongochieu2810 daongochieu2810 merged commit b1bd76a into AY2021S1-CS2103T-W10-2:master Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update DevGuide (Logic - UI relationship) Update UserGuide (Select and Close Command)
6 participants