Update tests #262
Merged
Update tests #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into test # Conflicts: # src/test/java/seedu/address/model/recipe/RecipeTest.java
TianYong-Goh
reviewed
Nov 7, 2020
| @@ -10,8 +10,9 @@ | |||
| public class Instruction { | |||
|
|
|||
| public static final String MESSAGE_CONSTRAINTS = | |||
| "Instructions should only contain alphanumeric characters, punctuations and spaces, " | |||
| + "and it should not be blank. They are separated by full stop"; | |||
| "1. Instruction cannot be empty \n" | |||
There was a problem hiding this comment.
Maybe can rephrase this line?
Instruction should not be empty?
Comment on lines
5
to
9
| import static seedu.address.logic.commands.CommandTestUtil.VALID_INGREDIENT_MARGARITAS; | ||
| import static seedu.address.logic.commands.CommandTestUtil.VALID_INGREDIENT_SANDWICH; | ||
| import static seedu.address.logic.commands.CommandTestUtil.VALID_NAME_MARGARITAS; | ||
| import static seedu.address.logic.commands.CommandTestUtil.VALID_QUANTITY_MARGARITAS; | ||
| import static seedu.address.logic.commands.CommandTestUtil.VALID_QUANTITY_SANDWICH; |
There was a problem hiding this comment.
I feel is more readable to use this instead of putting CommandTestUtil in front
TianYong-Goh
approved these changes
Nov 7, 2020
| @@ -1,7 +1,5 @@ | |||
| package seedu.address.logic.parser.data; | |||
|
|
|||
| import static seedu.address.commons.core.Messages.MESSAGE_INVALID_COMMAND_FORMAT; | |||
There was a problem hiding this comment.
I feel use this is more readable
daongochieu2810
approved these changes
Nov 7, 2020
…into test # Conflicts: # src/main/java/seedu/address/logic/parser/data/ImageParser.java
# Conflicts: # src/main/java/seedu/address/logic/parser/data/ImageParser.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.