Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add List Consumption UI #88

Merged

Conversation

TianYong-Goh
Copy link
Collaborator

No description provided.

@TianYong-Goh TianYong-Goh added this to the v1.2b milestone Oct 11, 2020
@TianYong-Goh TianYong-Goh linked an issue Oct 11, 2020 that may be closed by this pull request
@TianYong-Goh TianYong-Goh self-assigned this Oct 11, 2020
@codecov-io
Copy link

Codecov Report

Merging #88 into master will decrease coverage by 1.25%.
The diff coverage is 22.72%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #88      +/-   ##
============================================
- Coverage     68.33%   67.08%   -1.26%     
  Complexity      527      527              
============================================
  Files            95       97       +2     
  Lines          1740     1774      +34     
  Branches        194      199       +5     
============================================
+ Hits           1189     1190       +1     
- Misses          482      515      +33     
  Partials         69       69              
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/seedu/address/logic/LogicManager.java 59.09% <0.00%> (-2.82%) 3.00 <0.00> (ø)
...du/address/logic/commands/SearchRecipeCommand.java 100.00% <ø> (ø) 6.00 <0.00> (ø)
...rc/main/java/seedu/address/ui/ConsumptionCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...in/java/seedu/address/ui/ConsumptionListPanel.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
src/main/java/seedu/address/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/RecipeCard.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...va/seedu/address/logic/commands/CommandResult.java 78.26% <80.00%> (-2.70%) 10.00 <3.00> (ø)
...java/seedu/address/logic/commands/ExitCommand.java 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
...java/seedu/address/logic/commands/HelpCommand.java 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
...address/logic/commands/ListConsumptionCommand.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebe63f3...6f8af77. Read the comment docs.

Copy link
Collaborator

@caitlinjee caitlinjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@oliviajohansen oliviajohansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@jiaqi20 jiaqi20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TianYong-Goh TianYong-Goh merged commit 21d3abb into AY2021S1-CS2103T-W10-2:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update UI to Reflect Consumption List
6 participants