Support task deadline #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
============================================
- Coverage 59.42% 59.26% -0.16%
- Complexity 597 598 +1
============================================
Files 109 109
Lines 2228 2234 +6
Branches 274 275 +1
============================================
Hits 1324 1324
- Misses 825 830 +5
- Partials 79 80 +1
Continue to review full report at Codecov.
|
GeNiaaz
approved these changes
Oct 19, 2020
| @@ -42,7 +42,7 @@ task coverage(type: JacocoReport) { | |||
|
|
|||
| dependencies { | |||
| String jUnitVersion = '5.4.0' | |||
| String javaFxVersion = '11' | |||
| String javaFxVersion = '11.0.1' | |||
There was a problem hiding this comment.
WOW this has been bugging me for the longest time, thanks for finding and changing it
| @@ -37,8 +39,11 @@ public AddTaskCommand parse(String args) throws ParseException { | |||
| ParserUtil.parseTaskBasicInformation(argMultimap.getValue(PREFIX_TASK_PROGRESS).get())); | |||
| boolean taskStatus = Boolean.parseBoolean( | |||
| ParserUtil.parseTaskBasicInformation(argMultimap.getValue(PREFIX_TASK_IS_DONE).get())); | |||
|
|
|||
| Task task = new Task(taskName, null, null, taskProgress, taskStatus); | |||
| Deadline taskDeadline = null; | |||
There was a problem hiding this comment.
Why set it to null here? Why not declare the variable below.
| @@ -46,7 +46,7 @@ public TaskFilterCommand parse(String args) throws ParseException { | |||
|
|
|||
| if (argMultimap.getValue(PREFIX_TASK_DEADLINE).isPresent()) { | |||
| Deadline deadline = ParserUtil.parseDeadline(argMultimap.getValue(PREFIX_TASK_DEADLINE).get()); | |||
| predicate = task -> task.getDeadline().equals(deadline); | |||
| predicate = task -> task.isDueOn(deadline); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.