Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for remaining Teammate associated classes #283

Conversation

GeNiaaz
Copy link

@GeNiaaz GeNiaaz commented Nov 5, 2020

Resolve #284

Tests for the following classes included:

  • AddTeammateParticipation / Parser
  • DeleteTeammateParticipation / Parser
  • EditTeammate / Parser
  • DeleteTeammateCommand

@GeNiaaz GeNiaaz added this to the v1.4 milestone Nov 5, 2020
@GeNiaaz GeNiaaz self-assigned this Nov 5, 2020
@codecov-io
Copy link

codecov-io commented Nov 6, 2020

Codecov Report

Merging #283 into master will increase coverage by 4.41%.
The diff coverage is 73.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #283      +/-   ##
============================================
+ Coverage     63.82%   68.23%   +4.41%     
- Complexity      872      911      +39     
============================================
  Files           136      136              
  Lines          3074     3076       +2     
  Branches        414      414              
============================================
+ Hits           1962     2099     +137     
+ Misses         1001      847     -154     
- Partials        111      130      +19     
Impacted Files Coverage Δ Complexity Δ
...seedu/address/commons/core/index/GitUserIndex.java 72.72% <0.00%> (-5.06%) 8.00 <1.00> (+2.00) ⬇️
...n/java/seedu/address/commons/core/index/Index.java 100.00% <ø> (ø) 10.00 <0.00> (ø)
...ss/logic/commands/project/EditTeammateCommand.java 79.26% <ø> (+79.26%) 8.00 <0.00> (+8.00)
...eedu/address/logic/parser/MainCatalogueParser.java 61.19% <0.00%> (ø) 31.00 <0.00> (ø)
src/main/java/seedu/address/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...mands/project/AddTeammateParticipationCommand.java 100.00% <100.00%> (+100.00%) 7.00 <5.00> (+7.00)
...ds/project/DeleteTeammateParticipationCommand.java 53.33% <100.00%> (+53.33%) 6.00 <4.00> (+6.00)
.../parser/AddTeammateParticipationCommandParser.java 100.00% <100.00%> (ø) 2.00 <1.00> (?)
...rser/DeleteTeammateParticipationCommandParser.java 100.00% <100.00%> (ø) 2.00 <1.00> (?)
...rc/main/java/seedu/address/model/ModelManager.java 84.92% <100.00%> (-0.12%) 43.00 <0.00> (-1.00)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5626917...93150c4. Read the comment docs.

Copy link

@lucastai98 lucastai98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lucastai98 lucastai98 merged commit 72b7612 into AY2021S1-CS2103T-W10-3:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write tests for remaining Teammate related classes
3 participants