Refactor phone to deadline in project #68
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lll-jy
requested changes
Oct 4, 2020
| @@ -326,7 +326,7 @@ Use case ends. | |||
| **MSS:** | |||
|
|
|||
| 1. Team leader create a new team member profile. | |||
| 2. TMTS asks for the details of the team member such as name, phone number and email address. | |||
| 2. TMTS asks for the details of the team member such as name, deadline number and email address. | |||
There was a problem hiding this comment.
deadline number may be changed? e.g. deadline datetime
| @@ -351,7 +351,7 @@ Use case ends. | |||
| 1. Team leader chooses to edit a team member's profile. | |||
| 2. PTS asks for the name of the team member whose profile is to be edited. | |||
| 3. Team leader keys in the name of the team member. | |||
| 4. TMTS asks for the new information of team member such as name, phone number and email address. | |||
| 4. TMTS asks for the new information of team member such as name, deadline number and email address. | |||
| @@ -93,7 +93,7 @@ In `src/test/data/`, data meant for testing purposes are stored. While keeping t | |||
| { | |||
| "projects": [ { | |||
| "name": "Project with invalid name field: Ha!ns Mu@ster", | |||
| "phone": "9482424", | |||
| "deadline": "9482424", | |||
| @@ -0,0 +1,103 @@ | |||
| package seedu.address.model.project; | |||
There was a problem hiding this comment.
I can see that all your code works. But would it be easier if we use java LocalDate and LocalDateTime to deal with it? And it may be easier for us in the future work if we want to filter projects by deadline.
| import seedu.address.model.project.Email; | ||
| import seedu.address.model.project.Name; | ||
| import seedu.address.model.project.Phone; |
There was a problem hiding this comment.
All the examples may need to updated according to the validation regex.
| @@ -1,12 +1,12 @@ | |||
| { | |||
There was a problem hiding this comment.
This file may need to be changed (for deadline regex)
| @@ -4,9 +4,9 @@ | |||
| import static seedu.address.commons.core.Messages.MESSAGE_INVALID_PROJECT_DISPLAYED_INDEX; | |||
| import static seedu.address.commons.core.Messages.MESSAGE_UNKNOWN_COMMAND; | |||
| import static seedu.address.logic.commands.CommandTestUtil.ADDRESS_DESC_AMY; | |||
| import static seedu.address.logic.commands.CommandTestUtil.DEADLINE_DESC_A; | |||
There was a problem hiding this comment.
I think we'd better keep the format aligned, say use DEADLINE_DESC_AMY as the name. And we can change AMY to project names together for future refactoring work.
| @@ -43,8 +43,8 @@ | |||
|
|
|||
| public static final String NAME_DESC_AMY = " " + PREFIX_NAME + VALID_NAME_AMY; | |||
| public static final String NAME_DESC_BOB = " " + PREFIX_NAME + VALID_NAME_BOB; | |||
| public static final String PHONE_DESC_AMY = " " + PREFIX_PHONE + VALID_PHONE_AMY; | |||
| public static final String PHONE_DESC_BOB = " " + PREFIX_PHONE + VALID_PHONE_BOB; | |||
| public static final String DEADLINE_DESC_A = " " + PREFIX_DEADLINE + VALID_DEADLINE_A; | |||
| @@ -2,10 +2,10 @@ | |||
|
|
|||
| import static org.junit.jupiter.api.Assertions.assertFalse; | |||
| import static org.junit.jupiter.api.Assertions.assertTrue; | |||
| import static seedu.address.logic.commands.CommandTestUtil.DESC_AMY; | |||
| import static seedu.address.logic.commands.CommandTestUtil.DESC_BOB; | |||
| import static seedu.address.logic.commands.CommandTestUtil.DESC_A; | |||
|
Opened a new branch for this, will close this PR and migrate to another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.