Update Participation class and create corresponding methods in Project #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T-Fang
added
enhancement
GeNiaaz
approved these changes
Oct 4, 2020
| * What changes made: | ||
| * added dependencies of it in and related collections; | ||
| * added related test cases. | ||
|
|
||
| * **Model modification**: Update Participation class and create corresponding methods in Project. (Pull request: Pull request [\#71](https://github.com/AY2021S1-CS2103T-W10-3/tp/pull/71)) |
Comment on lines
39
to
+40
| * Added documentation for basic task-related features. | ||
| * Came up with the first draft of feature list. |
There was a problem hiding this comment.
Can consider linking this to your commit?
| * Developer Guide: | ||
| * Wrote first draft of non-functional requirements. | ||
| * Wrote first draft of non-functional requirements. (Pull Request [\#54](https://github.com/AY2021S1-CS2103T-W10-3/tp/pull/54)) | ||
|
|
||
| * **Community**: | ||
| * Updated `README.md` for team repository. |
Comment on lines
+38
to
+44
| public Participation(Person person, Project project, Role role) { | ||
| this.person = person; | ||
| this.project = project; | ||
| this.role = role; | ||
| tasks = new HashSet<>(); | ||
| meetings = new HashSet<>(); | ||
| } |
There was a problem hiding this comment.
Good implementation of the Association class, we'll see how this plays out when we build the subsequent features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.