Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor project tags #80

Merged

Conversation

GeNiaaz
Copy link

@GeNiaaz GeNiaaz commented Oct 5, 2020

  • Solved merge conflicts

  • project tag background is not coloured, yet to fix that issue. However, logic and everything else is sound

resolve #79

GeNiaaz added 3 commits October 5, 2020 13:30
# Conflicts:
#	src/main/java/seedu/address/logic/commands/EditCommand.java
#	src/main/java/seedu/address/logic/parser/AddCommandParser.java
#	src/main/java/seedu/address/logic/parser/EditCommandParser.java
#	src/main/java/seedu/address/model/project/Project.java
#	src/main/java/seedu/address/storage/JsonAdaptedProject.java
#	src/main/java/seedu/address/ui/ProjectCard.java
#	src/main/resources/view/ProjectListCard.fxml
#	src/test/java/seedu/address/logic/parser/AddCommandParserTest.java
#	src/test/java/seedu/address/storage/JsonAdaptedProjectTest.java
#	src/test/java/seedu/address/testutil/ProjectBuilder.java
@GeNiaaz GeNiaaz added this to the v1.2 milestone Oct 5, 2020
@GeNiaaz GeNiaaz self-assigned this Oct 5, 2020
Copy link

@lucastai98 lucastai98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lucastai98 lucastai98 merged commit 3c43ddf into AY2021S1-CS2103T-W10-3:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Project class attributes Tag => ProjectTag
2 participants