Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardise command input and parsing structure #120

Merged
merged 32 commits into from
Oct 18, 2020
Merged

Standardise command input and parsing structure #120

merged 32 commits into from
Oct 18, 2020

Conversation

fyshhh
Copy link

@fyshhh fyshhh commented Oct 17, 2020

Standardised references to contact-related commands and updated the input and parsing structure by changing AddressBookParser's regex parsing structure. Many test cases were changed to adopt this new parsing structure. Resolves #99

fyshhh and others added 16 commits October 15, 2020 19:32
@fyshhh
Update AddCommand related classes to AddContactCommand
7a509e1
@fyshhh
Update DeleteCommand related classes to DeleteContactCommand
2599b27
@chan-j-d
Create TagManager interface and implementing class
5838578
@chan-j-d
Add copy method to TagManager
695280d
@chan-j-d
Change copy method to mutate TagManager instead of returning copy
c1554e5
@chan-j-d
Implement TagManager in AddressBook
062e67c 
AddressBook was chosen as it is largely a separate implementation from
ReadOnlyAddressBook unlike Model. As such, changing the underlying
functionality does not significantly affect the rest of the program,
especially other stubs that have been implemented.
@chan-j-d
Implement search by tags in Model and implementing classes
8e2a9e4 
As the commands only interact with the Model class, Model must contain
the method getPersonsWithTag(Tag).
@fyshhh
Update EditCommand related classes to EditContactCommand
cd3464b
@chan-j-d
Update handling of non-existent Tag keys
e747f46 
When a Tag does not exist in the TagManager, an empty Set will be
returned instead of null. To complement this, when removing Person
objects from a Tag in TagManagerImpl, if the Set becomes empty, the key
is deleted.
@chan-j-d
Create TagManagerImplTest.java
f63669d
@chan-j-d
Add integration tests between AddressBook and TagManager
7127946
@chan-j-d
Fix checkstyle and test-related issues
473b7ce
@fyshhh
Update FindCommand related classes to FindContactCommand
0485afc
@fyshhh
Update ListCommand related classes to ListContactCommand
c318acd
@fyshhh
Update parser and event-functionality commands to use new command str…
596f9b2 
…ucture
@fyshhh
Update test cases to support new command structure
221405f
@fyshhh fyshhh added this to the v1.3 milestone Oct 17, 2020
@fyshhh fyshhh self-assigned this Oct 17, 2020
@codecov-io
Copy link

codecov-io commented Oct 17, 2020 •
edited

Codecov Report

Merging #120 into master will increase coverage by 1.22%.
The diff coverage is 70.83%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #120      +/-   ##
============================================
+ Coverage     56.88%   58.11%   +1.22%     
- Complexity      457      494      +37     
============================================
  Files            93       97       +4     
  Lines          1751     1874     +123     
  Branches        205      214       +9     
============================================
+ Hits            996     1089      +93     
- Misses          705      730      +25     
- Partials         50       55       +5
Impacted Files Coverage Δ Complexity Δ
.../seedu/address/logic/commands/AddEventCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...edu/address/logic/commands/DeleteEventCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...seedu/address/logic/commands/EditEventCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...seedu/address/logic/commands/FindEventCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ava/seedu/address/logic/commands/IntroCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...seedu/address/logic/commands/ListEventCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...edu/address/logic/commands/SortContactCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...address/logic/parser/DeleteEventCommandParser.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...address/logic/parser/SortContactCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f789747...697785c. Read the comment docs.

solkim-83
solkim-83 approved these changes Oct 17, 2020
View reviewed changes
Copy link
Collaborator

@solkim-83 solkim-83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for doing them up.

@fyshhh fyshhh added enhancement New feature or request priority.Medium Features of medium priority for development. labels Oct 17, 2020
chan-j-d
chan-j-d reviewed Oct 17, 2020
View reviewed changes
Copy link
Collaborator

@chan-j-d chan-j-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part. Would be nice to hear your opinions on my suggestions.

src/main/java/seedu/address/logic/commands/AddContactCommand.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/logic/parser/AddressBookParser.java Outdated Show resolved Hide resolved
@fyshhh
Copy link
Author

fyshhh commented Oct 18, 2020

Enumerations added (see conversation with @chan-j-d above for more details).

@fyshhh fyshhh merged commit 34e7397 into AY2021S1-CS2103T-W10-4:master Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chan-j-d chan-j-d chan-j-d left review comments

@solkim-83 solkim-83 solkim-83 approved these changes

@bangyiwu bangyiwu Awaiting requested review from bangyiwu

@LinkedInk LinkedInk Awaiting requested review from LinkedInk

Assignees

@fyshhh fyshhh

Labels
enhancement New feature or request priority.Medium Features of medium priority for development.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Standardising command input and parsing structure across both contact and event functionalities
4 participants
@fyshhh @codecov-io @chan-j-d @solkim-83