Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section about displaying introduction window to DG #185

Merged
merged 2 commits into from
Oct 29, 2020

Conversation

fyshhh
Copy link

@fyshhh fyshhh commented Oct 29, 2020

No description provided.

@fyshhh fyshhh added the type.DG Issues regarding the DeveloperGuide document. label Oct 29, 2020
@fyshhh fyshhh requested a review from chan-j-d October 29, 2020 19:13
@fyshhh fyshhh self-assigned this Oct 29, 2020
@codecov-io
Copy link

Codecov Report

Merging #185 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #185   +/-   ##
=========================================
  Coverage     66.17%   66.17%           
  Complexity      844      844           
=========================================
  Files           125      125           
  Lines          2862     2862           
  Branches        330      330           
=========================================
  Hits           1894     1894           
  Misses          806      806           
  Partials        162      162           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e561ebe...e4dd2d9. Read the comment docs.

Copy link
Collaborator

@LinkedInk LinkedInk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fyshhh fyshhh merged commit 3d05647 into AY2021S1-CS2103T-W10-4:master Oct 29, 2020
the system is aware that the application is in the phase of being set up. As a result, determining whether the
introduction window should be shown is done when the Ui is being created and filled in.

An important factor to consider when implementing this command is to prevent users from being to invoke it. This means
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo here, being able*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.DG Issues regarding the DeveloperGuide document.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants