-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit Time class to allow more time input formats #237
Edit Time class to allow more time input formats #237
Conversation
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
============================================
+ Coverage 60.60% 61.37% +0.76%
- Complexity 886 923 +37
============================================
Files 140 140
Lines 3315 3350 +35
Branches 391 396 +5
============================================
+ Hits 2009 2056 +47
+ Misses 1128 1117 -11
+ Partials 178 177 -1
Continue to review full report at Codecov.
|
@@ -41,7 +41,7 @@ | |||
+ "[" + PREFIX_ADD_PERSON + "CONTACT_INDEX_LIST]\n" | |||
+ "Example: " + COMMAND_WORD + " " + COMMAND_TYPE + " " | |||
+ PREFIX_DESCRIPTION + "CS2103 Team meeting" + " " | |||
+ PREFIX_DATETIME + "12-12-1234 12:34" | |||
+ PREFIX_DATETIME + "12-10-20 12:00 " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this is inconsistent with the actual pattern below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Previously, only the following format for event time was allowed as an user input:
I've changed the Time class to accept more formats such as: