Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Time class to allow more time input formats #237

Merged
merged 15 commits into from
Nov 5, 2020

Conversation

solkim-83
Copy link
Collaborator

Previously, only the following format for event time was allowed as an user input:

  1. dd-MM-yyyy HH:mm

I've changed the Time class to accept more formats such as:

  1. dd-MM-yyyy HH:mm
  2. yyyy-MM-dd HH:mm
  3. and such that [.][/][-] can be used interchangeably to key in the date and time.

@solkim-83 solkim-83 added enhancement New feature or request priority.Medium Features of medium priority for development. labels Nov 3, 2020
@solkim-83 solkim-83 self-assigned this Nov 3, 2020
@solkim-83 solkim-83 added this to the v1.4 milestone Nov 3, 2020
@codecov-io
Copy link

codecov-io commented Nov 3, 2020

Codecov Report

Merging #237 into master will increase coverage by 0.76%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #237      +/-   ##
============================================
+ Coverage     60.60%   61.37%   +0.76%     
- Complexity      886      923      +37     
============================================
  Files           140      140              
  Lines          3315     3350      +35     
  Branches        391      396       +5     
============================================
+ Hits           2009     2056      +47     
+ Misses         1128     1117      -11     
+ Partials        178      177       -1     
Impacted Files Coverage Δ Complexity Δ
...address/logic/commands/events/AddEventCommand.java 55.22% <ø> (ø) 10.00 <0.00> (ø)
src/main/java/seedu/address/model/event/Time.java 63.82% <100.00%> (ø) 15.00 <1.00> (ø)
.../logic/parser/events/DeleteEventCommandParser.java 50.00% <0.00%> (-7.15%) 2.00% <0.00%> (ø%)
...ddress/logic/commands/events/EditEventCommand.java 71.96% <0.00%> (-0.26%) 16.00% <0.00%> (ø%)
src/main/java/seedu/address/model/tag/TagTree.java 100.00% <0.00%> (ø) 7.00% <0.00%> (ø%)
...java/seedu/address/logic/commands/CommandType.java 100.00% <0.00%> (ø) 7.00% <0.00%> (+2.00%)
...java/seedu/address/logic/commands/CommandWord.java 100.00% <0.00%> (ø) 9.00% <0.00%> (+4.00%)
...ic/parser/contacts/DeleteContactCommandParser.java 100.00% <0.00%> (ø) 2.00% <0.00%> (ø%)
...main/java/seedu/address/model/tag/TagTreeImpl.java 87.64% <0.00%> (+0.14%) 44.00% <0.00%> (+2.00%)
...in/java/seedu/address/logic/parser/ParserUtil.java 89.61% <0.00%> (+0.27%) 26.00% <0.00%> (ø%)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdd6133...bec8339. Read the comment docs.

@@ -41,7 +41,7 @@
+ "[" + PREFIX_ADD_PERSON + "CONTACT_INDEX_LIST]\n"
+ "Example: " + COMMAND_WORD + " " + COMMAND_TYPE + " "
+ PREFIX_DESCRIPTION + "CS2103 Team meeting" + " "
+ PREFIX_DATETIME + "12-12-1234 12:34"
+ PREFIX_DATETIME + "12-10-20 12:00 "
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is inconsistent with the actual pattern below.

Copy link
Collaborator

@LinkedInk LinkedInk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LinkedInk LinkedInk merged commit 3eaf2cb into AY2021S1-CS2103T-W10-4:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority.Medium Features of medium priority for development.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D] [Athena] Event date editing is tedious Update events to accept more time formats
4 participants