Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update add event command to throw the correct exception #247

Conversation

LinkedInk
Copy link
Collaborator

@LinkedInk LinkedInk commented Nov 5, 2020

Throws CommandException correctly instead of IndexOutOfBoundsException which causes the app to not respond. Closes #248

@LinkedInk LinkedInk added bug Something isn't working severity.High Bugs of high priority to fix. labels Nov 5, 2020
@LinkedInk LinkedInk added this to the v1.4 milestone Nov 5, 2020
@LinkedInk LinkedInk self-assigned this Nov 5, 2020
@codecov-io
Copy link

Codecov Report

Merging #247 into master will decrease coverage by 0.06%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #247      +/-   ##
============================================
- Coverage     61.37%   61.31%   -0.07%     
  Complexity      923      923              
============================================
  Files           140      140              
  Lines          3350     3355       +5     
  Branches        396      397       +1     
============================================
+ Hits           2056     2057       +1     
- Misses         1117     1120       +3     
- Partials        177      178       +1     
Impacted Files Coverage Δ Complexity Δ
...address/logic/commands/events/AddEventCommand.java 52.77% <40.00%> (-2.45%) 10.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e28518...b3001e9. Read the comment docs.

Copy link
Collaborator

@solkim-83 solkim-83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@solkim-83 solkim-83 merged commit 1cdacba into AY2021S1-CS2103T-W10-4:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working severity.High Bugs of high priority to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App does not respond when creating an event with out of bounds person index
3 participants