Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PPP, amend minor errors in DG and UG #250

Merged
merged 3 commits into from
Nov 5, 2020
Merged

Add PPP, amend minor errors in DG and UG #250

merged 3 commits into from
Nov 5, 2020

Conversation

solkim-83
Copy link
Collaborator

  1. Added PPP file
  2. Amended formatting errors on DG use cases
  3. Added use case on sort event command.
  4. Capitalize the first letter of the use case title
  5. Added new time input format description for UG

@solkim-83 solkim-83 self-assigned this Nov 5, 2020
@solkim-83 solkim-83 added documentation Improvements or additions to documentation enhancement New feature or request type.DG Issues regarding the DeveloperGuide document. type.UG Issues regarding the UserGuide document. labels Nov 5, 2020
@solkim-83 solkim-83 added this to the v1.4 milestone Nov 5, 2020
bangyiwu
bangyiwu reviewed Nov 5, 2020
View reviewed changes
docs/UserGuide.md
* [.] (full stop)
* [/] (slash)
* [-] (hyphen)
* [:] (colon)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can people use a mix of these symbols? for example 2020.11/12 23-00? if they can maybe show an actual example, I think it will be even clearer than it is now

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. Have included the example below.

LinkedInk
LinkedInk approved these changes Nov 5, 2020
View reviewed changes
Copy link
Collaborator

@LinkedInk LinkedInk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LinkedInk LinkedInk merged commit 0ee16fc into AY2021S1-CS2103T-W10-4:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bangyiwu bangyiwu bangyiwu left review comments

@LinkedInk LinkedInk LinkedInk approved these changes

Assignees

@solkim-83 solkim-83

Labels
documentation Improvements or additions to documentation enhancement New feature or request type.DG Issues regarding the DeveloperGuide document. type.UG Issues regarding the UserGuide document.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@solkim-83 @bangyiwu @LinkedInk