Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task storage load save #115

Merged

Conversation

Asuraxsoul
Copy link

Fixes #81
Add GUI related Task files, hide from GUI MainWindow for now.
Fixes #45
Save Task details into addressBook.txt data file in Json format.
Load Task from addressBook.txt data file still in progress.

@Asuraxsoul Asuraxsoul self-assigned this Oct 18, 2020
@Asuraxsoul Asuraxsoul added priority.Medium severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product. labels Oct 18, 2020
@Asuraxsoul Asuraxsoul added this to the v1.3 milestone Oct 18, 2020
@codecov-io
Copy link

Codecov Report

Merging #115 into master will decrease coverage by 3.93%.
The diff coverage is 9.34%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #115      +/-   ##
============================================
- Coverage     62.68%   58.74%   -3.94%     
+ Complexity      507      498       -9     
============================================
  Files           102      105       +3     
  Lines          1865     1966     +101     
  Branches        177      189      +12     
============================================
- Hits           1169     1155      -14     
- Misses          648      760     +112     
- Partials         48       51       +3     
Impacted Files Coverage Δ Complexity Δ
.../java/seedu/address/logic/commands/AddCommand.java 28.57% <ø> (ø) 8.00 <0.00> (ø)
.../seedu/address/logic/parser/TaskCommandParser.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...c/main/java/seedu/address/model/task/Deadline.java 71.42% <0.00%> (-21.17%) 8.00 <0.00> (ø)
src/main/java/seedu/address/model/task/Event.java 77.14% <0.00%> (-22.86%) 9.00 <0.00> (ø)
src/main/java/seedu/address/model/task/Task.java 25.00% <0.00%> (-75.00%) 4.00 <0.00> (ø)
src/main/java/seedu/address/model/task/Todo.java 74.07% <0.00%> (-16.84%) 7.00 <0.00> (ø)
...in/java/seedu/address/storage/JsonAdaptedTask.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
src/main/java/seedu/address/ui/MainWindow.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/TaskCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
src/main/java/seedu/address/ui/TaskListPanel.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d348b9...a1557a8. Read the comment docs.

Copy link
Collaborator

@peironggg peironggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job saving these Task info into .json, we rly need tht

Copy link
Collaborator

@wilinetan wilinetan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the GUI for tasks and saving tasks locally!

@Asuraxsoul Asuraxsoul merged commit cf0c620 into AY2021S1-CS2103T-W11-2:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.Medium severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement showing tasks on GUI Save Tasks automatically as text files
4 participants