Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View ungraded missions and quests #146

Merged

Conversation

wilinetan
Copy link
Collaborator

@wilinetan wilinetan commented Oct 21, 2020

Fixes #25
Fixes #137
Fixes #148

@wilinetan wilinetan added type.Story A user story priority.High severity.High A flaw that affects most users and causes major problems for users. i.e. makes the product unusable. labels Oct 21, 2020
@wilinetan wilinetan added this to the v1.3b milestone Oct 21, 2020
@codecov-io
Copy link

codecov-io commented Oct 21, 2020

Codecov Report

Merging #146 into master will decrease coverage by 1.32%.
The diff coverage is 17.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #146      +/-   ##
============================================
- Coverage     53.11%   51.78%   -1.33%     
- Complexity      505      509       +4     
============================================
  Files           111      113       +2     
  Lines          2169     2242      +73     
  Branches        220      234      +14     
============================================
+ Hits           1152     1161       +9     
- Misses          959     1017      +58     
- Partials         58       64       +6     
Impacted Files Coverage Δ Complexity Δ
...dress/logic/commands/ViewConsultationsCommand.java 54.54% <0.00%> (-15.46%) 2.00 <0.00> (-1.00)
...ess/logic/commands/ViewMissionDeadlineCommand.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...s/logic/commands/ViewPastConsultationsCommand.java 54.54% <0.00%> (-15.46%) 2.00 <0.00> (-1.00)
...gic/commands/ViewUpcomingConsultationsCommand.java 54.54% <0.00%> (-15.46%) 2.00 <0.00> (-1.00)
...ain/java/seedu/address/logic/parser/CliSyntax.java 83.33% <ø> (ø) 1.00 <0.00> (ø)
.../seedu/address/logic/parser/ViewCommandParser.java 72.41% <0.00%> (-5.37%) 7.00 <0.00> (ø)
src/main/java/seedu/address/model/AddressBook.java 54.68% <0.00%> (-1.77%) 18.00 <0.00> (ø)
...rc/main/java/seedu/address/model/ModelManager.java 68.13% <0.00%> (+1.83%) 28.00 <0.00> (+1.00)
...main/java/seedu/address/model/mission/Mission.java 69.23% <ø> (ø) 8.00 <0.00> (ø)
...main/java/seedu/address/model/quest/QuestList.java 29.41% <0.00%> (-42.02%) 3.00 <0.00> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 866e27a...c85a154. Read the comment docs.

Copy link
Collaborator

@peironggg peironggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hard work :)

@peironggg peironggg merged commit a748ca0 into AY2021S1-CS2103T-W11-2:master Oct 21, 2020
@wilinetan wilinetan deleted the view-ungraded-command branch October 29, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High severity.High A flaw that affects most users and causes major problems for users. i.e. makes the product unusable. type.Story A user story
Projects
None yet
3 participants