Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tests for EditLoginCommand and Username #170

Merged
merged 9 commits into from
Oct 25, 2020

Conversation

peironggg
Copy link
Collaborator

@peironggg peironggg commented Oct 24, 2020

Fixes #171
Fixes #172
Fixes #173

@peironggg peironggg added this to the v1.3b milestone Oct 24, 2020
@codecov-io
Copy link

Codecov Report

Merging #170 into master will increase coverage by 5.38%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #170      +/-   ##
============================================
+ Coverage     45.84%   51.22%   +5.38%     
- Complexity      482      518      +36     
============================================
  Files           115      115              
  Lines          2360     2360              
  Branches        255      255              
============================================
+ Hits           1082     1209     +127     
+ Misses         1210     1062     -148     
- Partials         68       89      +21     
Impacted Files Coverage Δ Complexity Δ
.../main/java/seedu/address/model/login/Username.java 80.00% <ø> (+60.00%) 7.00 <0.00> (+6.00)
...rc/main/java/seedu/address/model/ModelManager.java 59.45% <0.00%> (+2.70%) 30.00% <0.00%> (+1.00%)
...main/java/seedu/address/commons/util/FileUtil.java 77.27% <0.00%> (+4.54%) 9.00% <0.00%> (+2.00%)
src/main/java/seedu/address/model/UserLogin.java 89.65% <0.00%> (+34.48%) 10.00% <0.00%> (+4.00%)
...ain/java/seedu/address/scraper/ScraperManager.java 37.20% <0.00%> (+37.20%) 14.00% <0.00%> (+14.00%)
...seedu/address/logic/commands/EditLoginCommand.java 92.30% <0.00%> (+92.30%) 7.00% <0.00%> (+7.00%)
...ss/commons/exceptions/OsNotSupportedException.java 100.00% <0.00%> (+100.00%) 1.00% <0.00%> (+1.00%)
...ss/commons/exceptions/ScraperParsingException.java 100.00% <0.00%> (+100.00%) 1.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 335a2ba...983e3c0. Read the comment docs.

@wireseo
Copy link
Collaborator

wireseo commented Oct 25, 2020

Nice test cases! LGTM

@peironggg peironggg merged commit 267cac3 into AY2021S1-CS2103T-W11-2:master Oct 25, 2020
@peironggg peironggg deleted the test branch October 25, 2020 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Unit Tests for EditLoginDescriptor Add Unit Tests for Username Add Unit Tests for EditLoginCommand
3 participants