GUI/invalid messages #272
Merged
GUI/invalid messages #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #272 +/- ##
============================================
- Coverage 44.16% 44.07% -0.09%
- Complexity 521 523 +2
============================================
Files 128 128
Lines 2690 2709 +19
Branches 279 282 +3
============================================
+ Hits 1188 1194 +6
- Misses 1439 1453 +14
+ Partials 63 62 -1
Continue to review full report at Codecov.
|
wilinetan
added
priority.Medium
severity.Low
peironggg
reviewed
Nov 1, 2020
| @@ -11,7 +13,7 @@ | |||
| * Contains utility methods for populating {@code AddressBook} with sample data. | |||
| */ | |||
| public class SampleDataUtil { | |||
| public static Student[] getSamplePersons() { | |||
There was a problem hiding this comment.
Thanks for refactoring names!
| /** | ||
| * Sets the week and topic | ||
| */ | ||
| private void setWeekAndTopic() { |
There was a problem hiding this comment.
Awesome way to calculate how many weeks it has been since the start of the semester 👍
| @@ -284,7 +321,7 @@ private void handleSourceAcademy() { | |||
| private void handleUserGuide() { | |||
| try { | |||
| Desktop.getDesktop() | |||
| .browse(URI.create("https://ay2021s1-cs2103t-w11-2.github.io/tp/UserGuide.html#quick-start")); | |||
| .browse(URI.create(USER_GUIDE_URL)); | |||
| @@ -11,9 +16,37 @@ | |||
| public static final Quest TEST_QUEST = new Quest(TEST_QUEST_TITLE, TEST_QUEST_DEADLINE); | |||
|
|
|||
| public static final Quest TEST_QUEST_COPY = new Quest(TEST_QUEST_TITLE, TEST_QUEST_DEADLINE); | |||
| public static final Quest RUNIC_CARPETS = new QuestBuilder().withTitle("Runic Carpets") | |||
There was a problem hiding this comment.
Thumbs up for creating tests!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32
Fixes #241
Fixes #270