Add tests for quests, topics and greeting #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilinetan
added
type.Task
ngzhenteng
approved these changes
Nov 5, 2020
| @@ -18,6 +20,8 @@ public Topic() { | |||
| * @param outline outline of Topic | |||
| */ | |||
| public Topic(String week, String outline) { | |||
| requireNonNull(week); | |||
There was a problem hiding this comment.
Great protective measure!
| } | ||
|
|
||
| @Test | ||
| void getGreeting() { |
There was a problem hiding this comment.
Perhaps this test method signature could be setGreeting_validString_success()?
| private final List<Quest> questListTest = new ArrayList<>(); | ||
|
|
||
| @Test | ||
| void add_nullQuest_throwsNullPointerException() { |
There was a problem hiding this comment.
This type of checking is indeed really important, thank you for writing these tests cases!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #168