Dg update2 #371
Merged
Dg update2 #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asuraxsoul
added
documentation
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
=========================================
Coverage 61.59% 61.59%
Complexity 796 796
=========================================
Files 136 136
Lines 3101 3101
Branches 346 346
=========================================
Hits 1910 1910
Misses 1062 1062
Partials 129 129 Continue to review full report at Codecov.
|
wireseo
reviewed
Nov 9, 2020
| Expected: Similar to previous. | ||
|
|
||
| 1. _{ more test cases … }_ |
There was a problem hiding this comment.
Thanks for removing these!
| @@ -5,8 +5,8 @@ hide circle | |||
|
|
|||
| class AddXYZCommand { | |||
| /' Attributes '/ | |||
| + MESSAGE_SUCCESS: String | |||
| + MESSAGE_INVALID: String | |||
| <u>+ MESSAGE_SUCCESS: String | |||
There was a problem hiding this comment.
Good note of static variables!
| @@ -33,7 +31,7 @@ AddressBookParser -> AddCommandParser : parse("-e...") | |||
| activate AddCommandParser | |||
|
|
|||
| activate TaskCommandParser | |||
| AddCommandParser -> TaskCommandParser : parse("-e...") | |||
| AddCommandParser -> TaskCommandParser : parseEvent("-e...") | |||
There was a problem hiding this comment.
For Add Tasks do we not need a ParserUtil class?
There was a problem hiding this comment.
Ok I will add it in the next pr, thanks for mentioning it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.