Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update user guide #384

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Conversation

ngzhenteng
Copy link
Collaborator

Fix UG bugs

Fix UG bugs
@ngzhenteng ngzhenteng added this to the v1.4 milestone Nov 9, 2020
@peironggg
Copy link
Collaborator

Thanks for fixing 👍

@ngzhenteng ngzhenteng merged commit a886cd2 into AY2021S1-CS2103T-W11-2:master Nov 9, 2020
Copy link

@Asuraxsoul Asuraxsoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -177,8 +177,12 @@ this box.
#### 4.1.1 Top Bar
* The top bar includes the following components.
1. Summary information - A quick summary indicating the number of ungraded `Missions` and `Quests`, upcoming
`Consultations` and `Mastery Checks` as well as outstanding `Tasks` in Jarvis. Do note that graded `Missions` and
`Consultations` and `Mastery Checks` as well as all `Tasks` in Jarvis. Do note that graded `Missions` and

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding the caveat

`Quests`, as well as past `Consultations` and `Mastery Checks`, will not be indicated.

We refer to this summary as the `Summary` feature. The summary is presented as a sentence containing the
count of the fields stated in the previous paragraph, in the image above, it is the sentence "Remaining - Nothing!". The values are updated when Jarvis starts up and after a user command is entered.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding such detailed explanation to summary feature

` will remain the same, even if
the current time has passed the date and time of a `Consultation` or `Mastery Check`. Also, if a `Mission` or
`Quest` is graded while Jarvis is open, the number of ungraded `Mission` and `Quests` will remain the same.
* To get the updated values, simply re-start Jarvis or type in a command and hit the enter key on your keyboard.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that this bullet point under this section 6.1.5 is quite important. Maybe we can give a markdown box for caution?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is true, great suggestion! @peironggg could you help with this since you are working on the UG currently? thank you!

An example of a partial match will be `view -s do` resulting in John Doe being displayed.
Shows all `Students` that match (partial and full) the name entered after the command. The name is case-sensitive
and partial name matches will work, the following is an example. If you would like to look for your student Tommy
Hilfiger, you can simply type in `view -s Tom` and the student will be displayed. A full match on the other hand would be as such: key in the command `view -s John Doe` and John

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for elaborating more about the example

@@ -48,11 +48,11 @@ Given below are my contributions to the project.
* **Documentation**:
* User Guide:
* Created the first copy of the UserGuide in markdown format. [\#18](https://github.com/AY2021S1-CS2103T-W11-2/tp/pull/18)
* Added documentation for the features `view students`
* Added documentation for the features `View Students`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great spot!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants