Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement scraper outline to fetch mission titles #53

Merged
merged 4 commits into from
Sep 26, 2020

Conversation

peironggg
Copy link
Collaborator

Used chrome headless browser to navigate to sourceacademy, login and fetch mission titles.

@ngzhenteng ngzhenteng requested review from ngzhenteng and removed request for ngzhenteng September 25, 2020 16:03
Copy link
Collaborator

@ngzhenteng ngzhenteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks really good, this will definitely be important in enabling our features. In future pull requests we could possibly encapsulate the missions and deadlines as classes of their own with their own methods. Thank you!

@wireseo
Copy link
Collaborator

wireseo commented Sep 26, 2020

LGTM! Yes, this is amazing! A core feature that we really needed. :)

@peironggg peironggg merged commit b8ec8ea into AY2021S1-CS2103T-W11-2:master Sep 26, 2020
@peironggg peironggg added this to the v1.2 milestone Sep 29, 2020
@peironggg peironggg deleted the scraper branch September 29, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants