Add flags parser #77
Merged
Add flags parser #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
============================================
- Coverage 65.53% 65.01% -0.52%
Complexity 406 406
============================================
Files 80 81 +1
Lines 1381 1392 +11
Branches 134 135 +1
============================================
Hits 905 905
- Misses 443 454 +11
Partials 33 33
Continue to review full report at Codecov.
|
ngzhenteng
reviewed
Oct 5, 2020
|
|
||
| import com.google.common.collect.ImmutableSet; | ||
|
|
||
| public class Flag { |
There was a problem hiding this comment.
Maybe we could add a javadoc comment as follows:
Represents the string consisting of a dash followed by an alphabet such as "-m" included in the user's command.
wilinetan
reviewed
Oct 5, 2020
| @@ -20,14 +21,16 @@ public ViewCommand parse(String args) throws ParseException { | |||
| String.format(MESSAGE_INVALID_COMMAND_FORMAT, ViewCommand.MESSAGE_USAGE)); | |||
| } | |||
|
|
|||
| Flag commandFlag = ParserUtil.parseFlag(trimmedArgs); | |||
|
|
|||
| String[] nameKeywords = trimmedArgs.split("\\s+"); | |||
| String viewCommandOption = nameKeywords[0]; | |||
There was a problem hiding this comment.
I think can remove this line:
String viewCommandOption = nameKeywords[0];
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70
Fixes #78