Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort Day list and CalorieManager list #103

Merged
merged 4 commits into from
Oct 23, 2020

Conversation

hoperawr
Copy link

When adding a new day or editing an existing day, the day is added into the list in chronological order. However, I think we should not allow users to edit the date of the day as it does not make much sense.

Did the same thing for CalorieManager so that when inputs or outputs are added, they are in order of time.

@hoperawr hoperawr added enhancement New feature or request priority.Medium labels Oct 21, 2020
@hoperawr hoperawr added this to the v1.3a milestone Oct 21, 2020
@junhui-phoon junhui-phoon modified the milestones: v1.3a, v1.3 Oct 22, 2020
# Conflicts:
#	src/main/java/seedu/address/model/AddressBook.java
#	src/main/java/seedu/address/model/day/Day.java
#	src/test/java/seedu/address/logic/commands/FindCommandTest.java
@codecov-io
Copy link

Codecov Report

Merging #103 into master will increase coverage by 0.37%.
The diff coverage is 90.32%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #103      +/-   ##
============================================
+ Coverage     59.77%   60.15%   +0.37%     
- Complexity      453      467      +14     
============================================
  Files            91       91              
  Lines          1678     1709      +31     
  Branches        172      183      +11     
============================================
+ Hits           1003     1028      +25     
- Misses          597      598       +1     
- Partials         78       83       +5     
Impacted Files Coverage Δ Complexity Δ
...ain/java/seedu/address/model/day/calorie/Time.java 91.66% <0.00%> (+0.75%) 7.00 <1.00> (+2.00)
...eedu/address/model/day/calorie/CalorieManager.java 96.07% <87.50%> (-3.93%) 16.00 <6.00> (+4.00) ⬇️
src/main/java/seedu/address/model/day/Date.java 87.50% <100.00%> (+0.83%) 8.00 <1.00> (+1.00)
src/main/java/seedu/address/model/day/Day.java 97.43% <100.00%> (+0.06%) 17.00 <1.00> (+1.00)
...in/java/seedu/address/model/day/UniqueDayList.java 72.72% <100.00%> (-1.70%) 20.00 <0.00> (+4.00) ⬇️
...in/java/seedu/address/model/day/calorie/Input.java 27.27% <100.00%> (+3.46%) 3.00 <1.00> (+1.00)
...n/java/seedu/address/model/day/calorie/Output.java 27.27% <100.00%> (+3.46%) 3.00 <1.00> (+1.00)
src/main/java/seedu/address/model/tag/Tag.java 70.00% <0.00%> (-10.00%) 4.00% <0.00%> (-1.00%)
.../java/seedu/address/model/day/calorie/Calorie.java 100.00% <0.00%> (+16.66%) 3.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8236b3a...944460d. Read the comment docs.

@junhui-phoon junhui-phoon merged commit 809e756 into AY2021S1-CS2103T-W11-3:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority.Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants