Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where calorie data reset to 0 after editing #124

Merged

Conversation

junhui-phoon
Copy link

@junhui-phoon junhui-phoon commented Oct 23, 2020

Fixed bug where calorie data reset to 0 after editing.
A copy of the Calorie Manager is parsed to the Day constructor since every edit command creates a new Day object.
Since edit command does not edit any calorie values, this fix does not affect the integrity of Calorie Manager.

@junhui-phoon junhui-phoon added bug Something isn't working priority.High labels Oct 23, 2020
@junhui-phoon junhui-phoon added this to the v1.3 milestone Oct 23, 2020
@codecov-io
Copy link

Codecov Report

Merging #124 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #124      +/-   ##
============================================
+ Coverage     56.76%   56.78%   +0.02%     
  Complexity      467      467              
============================================
  Files            93       93              
  Lines          1811     1812       +1     
  Branches        191      191              
============================================
+ Hits           1028     1029       +1     
  Misses          700      700              
  Partials         83       83              
Impacted Files Coverage Δ Complexity Δ
...java/seedu/address/logic/commands/EditCommand.java 89.28% <100.00%> (+0.19%) 10.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2791209...6692f82. Read the comment docs.

@junhui-phoon junhui-phoon linked an issue Oct 23, 2020 that may be closed by this pull request
Copy link

@ethanso56 ethanso56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@ethanso56 ethanso56 merged commit 4996d3c into AY2021S1-CS2103T-W11-3:master Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Calorie Data deleted after editing weight
3 participants