Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sample Data bug #246

Merged
merged 2 commits into from
Nov 8, 2020
Merged

Fix Sample Data bug #246

merged 2 commits into from
Nov 8, 2020

Conversation

junhui-phoon
Copy link

No description provided.

@junhui-phoon junhui-phoon added this to the v1.4 milestone Nov 8, 2020
@junhui-phoon junhui-phoon self-assigned this Nov 8, 2020
wayne987
wayne987 suggested changes Nov 8, 2020
View reviewed changes
Copy link

@wayne987 wayne987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Abstract out the common code

wayne987
wayne987 approved these changes Nov 8, 2020
View reviewed changes
Copy link

@wayne987 wayne987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@junhui-phoon junhui-phoon merged commit bad46b7 into AY2021S1-CS2103T-W11-3:master Nov 8, 2020
@junhui-phoon junhui-phoon linked an issue Nov 8, 2020 that may be closed by this pull request
Modify SampleDataUtil to display more realistic data #147
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wayne987 wayne987 wayne987 approved these changes

Assignees

@junhui-phoon junhui-phoon

Labels
type.FunctionalityBug
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

Modify SampleDataUtil to display more realistic data
2 participants
@junhui-phoon @wayne987