Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI modifications #54

Merged
merged 8 commits into from
Oct 13, 2020
Merged

UI modifications #54

merged 8 commits into from
Oct 13, 2020

Conversation

junhui-phoon
Copy link

No description provided.

@junhui-phoon junhui-phoon added this to the v1.2 milestone Oct 10, 2020
@junhui-phoon junhui-phoon self-assigned this Oct 10, 2020
This was linked to issues Oct 10, 2020
Update the help message to refer to our user guide link #39
Closed
Modify UI #43
Closed
@junhui-phoon junhui-phoon marked this pull request as draft October 10, 2020 16:33
@codecov-io
Copy link

codecov-io commented Oct 10, 2020 •
edited

Codecov Report

Merging #54 into master will increase coverage by 0.14%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #54      +/-   ##
============================================
+ Coverage     64.80%   64.94%   +0.14%     
  Complexity      400      400              
============================================
  Files            79       79              
  Lines          1381     1378       -3     
  Branches        136      136              
============================================
  Hits            895      895              
+ Misses          453      450       -3     
  Partials         33       33
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/ui/DayCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/HelpWindow.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/UiManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 329d759...1e87309. Read the comment docs.

@junhui-phoon
Modify UI elements
9d026c9 
#PersonCard.java
Replaced fxml references of AB-3 to My Fitness Buddy (incomplete for model/Day.java class references).

#UIManager.java
Renamed CSS filename to ArmyTheme.css

#ArmyTheme.css
Changed the hex code of the UI colours to army green.

#MainWindow.fxml
#PersonListCard.fxml
#ResultDisplay.fxml
Reordering of the UI elements.
@junhui-phoon
Fix checkstyle errors
47539d0
@junhui-phoon
Copy link
Author

junhui-phoon commented Oct 11, 2020 •
edited

image

Current UI modifications for MVP

@junhui-phoon junhui-phoon marked this pull request as ready for review October 13, 2020 16:09
@junhui-phoon junhui-phoon requested review from wayne987 and removed request for ethanso56 October 13, 2020 16:09
@junhui-phoon
Copy link
Author

@wayne987 please review thanks

@junhui-phoon junhui-phoon removed the request for review from wayne987 October 13, 2020 16:12
@junhui-phoon junhui-phoon merged commit ab85671 into AY2021S1-CS2103T-W11-3:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@junhui-phoon junhui-phoon

Labels
priority.High UI
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

Modify UI Update the help message to refer to our user guide link
2 participants
@junhui-phoon @codecov-io