Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused 'add' command parameters #73

Conversation

junhui-phoon
Copy link

No description provided.

@junhui-phoon junhui-phoon self-assigned this Oct 14, 2020
@junhui-phoon
Copy link
Author

CI is expected to fail

@junhui-phoon junhui-phoon linked an issue Oct 14, 2020 that may be closed by this pull request
@junhui-phoon junhui-phoon added this to the v1.3 milestone Oct 14, 2020
#Day.java
Fixed 'add' command successful execute message

#LogicManagerTest.java
#CommandTestUtil.java
#AddCommandParserTest.java
Removed 'address' and 'email' parameters in test methods
@junhui-phoon junhui-phoon modified the milestones: v1.3, v1.2 Oct 14, 2020
@junhui-phoon
Copy link
Author

Before Fix:
image
After Fix:
image

Copy link

@ethanso56 ethanso56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@junhui-phoon junhui-phoon merged commit bda6e71 into AY2021S1-CS2103T-W11-3:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unused command parameters not removed
2 participants