Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused classes- address, email #82

Merged

Conversation

ethanso56
Copy link

No description provided.

@ethanso56 ethanso56 added this to the v1.3a milestone Oct 17, 2020
@ethanso56 ethanso56 self-assigned this Oct 17, 2020
@ethanso56 ethanso56 linked an issue Oct 17, 2020 that may be closed by this pull request
@codecov-io
Copy link

Codecov Report

Merging #82 into master will decrease coverage by 0.72%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #82      +/-   ##
============================================
- Coverage     65.74%   65.01%   -0.73%     
+ Complexity      411      397      -14     
============================================
  Files            81       79       -2     
  Lines          1439     1392      -47     
  Branches        141      133       -8     
============================================
- Hits            946      905      -41     
+ Misses          456      452       -4     
+ Partials         37       35       -2     
Impacted Files Coverage Δ Complexity Δ
...in/java/seedu/address/logic/parser/ParserUtil.java 49.01% <0.00%> (-8.36%) 10.00 <0.00> (-4.00)
src/main/java/seedu/address/model/day/Date.java 86.66% <ø> (ø) 7.00 <0.00> (ø)
...n/java/seedu/address/storage/JsonAdaptedInput.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../java/seedu/address/storage/JsonAdaptedOutput.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...java/seedu/address/logic/commands/EditCommand.java 96.36% <100.00%> (-0.56%) 12.00 <0.00> (ø)
...ain/java/seedu/address/logic/parser/CliSyntax.java 88.88% <100.00%> (-2.78%) 1.00 <0.00> (ø)
.../seedu/address/logic/parser/EditCommandParser.java 90.90% <100.00%> (-1.40%) 9.00 <0.00> (-2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f88aae...5c95750. Read the comment docs.

@junhui-phoon
Copy link

Looks good to me.

@junhui-phoon junhui-phoon merged commit 2b5a7f6 into AY2021S1-CS2103T-W11-3:master Oct 18, 2020
@junhui-phoon junhui-phoon modified the milestones: v1.3a, v1.3 Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete unused classes and prefixes
3 participants