Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various bugs with undo/redo, addvisit and reorganized parts of UG #173

Merged
merged 3 commits into from
Oct 29, 2020

Conversation

eugene3231
Copy link

@eugene3231 eugene3231 commented Oct 29, 2020

Fix bugs with

  1. undo/redo and addvisit editvisit and deletevisit,
  2. addvisit with vd/
  3. prescription and diagnosis mixup

Also increased clean startup cliniCal.jar window size

Also reorganized entire UG structure and shifted undo/redo into general commands
Also added a table for formatting legend after Introduction

chrome_1BRaJPBxlp

@eugene3231 eugene3231 added the bug Something isn't working label Oct 29, 2020
@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #173 into master will increase coverage by 0.16%.
The diff coverage is 62.06%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #173      +/-   ##
============================================
+ Coverage     63.10%   63.27%   +0.16%     
- Complexity      761      764       +3     
============================================
  Files           119      119              
  Lines          2889     2905      +16     
  Branches        344      345       +1     
============================================
+ Hits           1823     1838      +15     
- Misses          957      958       +1     
  Partials        109      109              
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/MainApp.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...n/java/seedu/address/commons/core/GuiSettings.java 69.23% <ø> (ø) 5.00 <0.00> (ø)
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...dress/logic/commands/AddProfilePictureCommand.java 36.66% <0.00%> (ø) 3.00 <0.00> (ø)
.../seedu/address/logic/commands/AddVisitCommand.java 63.15% <ø> (+3.15%) 7.00 <0.00> (ø)
...java/seedu/address/logic/commands/RedoCommand.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
...seedu/address/logic/commands/SaveVisitCommand.java 44.44% <0.00%> (-4.34%) 10.00 <0.00> (ø)
...java/seedu/address/logic/commands/UndoCommand.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
...ic/commands/appointment/AddAppointmentCommand.java 50.00% <0.00%> (-1.22%) 8.00 <0.00> (ø)
...ava/seedu/address/logic/parser/CliniCalParser.java 65.51% <ø> (ø) 15.00 <0.00> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5c4491...e2528d3. Read the comment docs.

@eugene3231 eugene3231 changed the title Fix various bugs Fix various bugs with undo/redo, addvisit and made reorganized parts of UG Oct 29, 2020
@eugene3231 eugene3231 changed the title Fix various bugs with undo/redo, addvisit and made reorganized parts of UG Fix various bugs with undo/redo, addvisit and reorganized parts of UG Oct 29, 2020
@eugene3231 eugene3231 added the documentation Improvements or additions to documentation label Oct 29, 2020
Copy link

@Michaeliaaa Michaeliaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Michaeliaaa Michaeliaaa merged commit 7ab9b12 into AY2021S1-CS2103T-W11-4:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants