Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gui-related bugs #230

Merged
merged 9 commits into from
Nov 2, 2020

Conversation

ktaekwon000
Copy link
Collaborator

@ktaekwon000 ktaekwon000 commented Nov 1, 2020

Closes #182, #193, #196, #198, #200, #204, #229.

@codecov
Copy link

codecov bot commented Nov 1, 2020

Codecov Report

Merging #230 into master will decrease coverage by 1.32%.
The diff coverage is 6.32%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #230      +/-   ##
============================================
- Coverage     64.13%   62.80%   -1.33%     
  Complexity      775      775              
============================================
  Files           119      120       +1     
  Lines          2919     2984      +65     
  Branches        346      350       +4     
============================================
+ Hits           1872     1874       +2     
- Misses          930      992      +62     
- Partials        117      118       +1     
Impacted Files Coverage Δ Complexity Δ
...n/java/seedu/address/commons/core/GuiSettings.java 69.23% <ø> (ø) 5.00 <0.00> (ø)
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...rc/main/java/seedu/address/ui/AppointmentCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...rc/main/java/seedu/address/ui/CalendarDisplay.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/HelpWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/PatientCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...c/main/java/seedu/address/ui/PatientListPanel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...java/seedu/address/ui/skin/CustomEightDaySkin.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...s/logic/parser/AddProfilePictureCommandParser.java 75.00% <60.00%> (-8.34%) 3.00 <0.00> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd4e0ea...cafbd64. Read the comment docs.

Copy link

@gsmoon97 gsmoon97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gsmoon97 gsmoon97 merged commit 4cb9fa4 into AY2021S1-CS2103T-W11-4:master Nov 2, 2020
@ktaekwon000 ktaekwon000 deleted the fix-gui-bugs branch November 7, 2020 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D] profile picture does not allign well
2 participants